MSC2998: Room Version 7 #2998
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # MSCXXXX: Room Version 7 | ||
|
|
||
| A new room version, `7`, is proposed using [room version 6](https://matrix.org/docs/spec/rooms/v6.html) as a base | ||
| and incorporating the following MSCs: | ||
|
|
||
| * [MSC2174](https://github.com/matrix-org/matrix-doc/pull/2174) - Move the `redacts` key to a sane place. | ||
| * [MSC2175](https://github.com/matrix-org/matrix-doc/pull/2175) - Remove the `creator` field from `m.room.create` events. | ||
| * [MSC2176](https://github.com/matrix-org/matrix-doc/pull/2176) - Update the redaction rules. | ||
| * [MSC2403](https://github.com/matrix-org/matrix-doc/pull/2403) - Add "knock" feature. | ||
|
|
||
|
|
||
| Though other MSCs are capable of being included in this version, they do not have sufficient implementation to be | ||
| considered stable enough for v7 rooms. A future room version may still include them. | ||
|
Member
There was a problem hiding this comment. This took me about 5 reads to understand - isn't it just saying, "other mscs aren't ready yet because they don't have impls"?
Member
Author
There was a problem hiding this comment. Indeed, but written a bit tersely for the spec. I'm open to suggestions for something slightly clearer though. There was a problem hiding this comment. Maybe
Member
Author
There was a problem hiding this comment. I've dropped the |
||
|
|
||
| Room version 7 upon being added to the specification shall be considered stable. No other room versions are affected | ||
| by this MSC. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no point in having two migrations of redaction format, we should just skip this step and go straight for mass redactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tulir I didn't include Mass Redactions as it doesn't currently have an implementation.
You're right in that putting MSC2244 and MSC2174, especially as the former builds on the latter, into the same room version makes sense though. I'd be happy to review/help with a Synapse PR for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, doesn't
content.redactshave to be protected from redaction now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is protected from redaction by MSC2176, that part works the same way for MSC2174 and MSC2244.