Closed
Conversation
4 tasks
t3chguy
requested changes
Mar 27, 2025
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
This feels like it has no point being in the js-sdk for an MSC PoC. Why not have it just live in the application you wish to support it, presumably EW? AccountDataEvents is extensible by the host app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-spec-proposals#4155
Checklist
public/exportedsymbols have accurate TSDoc documentation.