Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Display channel name in list command#756

Open
psrpinto wants to merge 5 commits intomatrix-org:developfrom
Automattic:fix-pending-name
Open

Display channel name in list command#756
psrpinto wants to merge 5 commits intomatrix-org:developfrom
Automattic:fix-pending-name

Conversation

@psrpinto
Copy link
Copy Markdown

@psrpinto psrpinto commented Jul 3, 2023

Fixes #349
Signed-off-by: Paulo Pinto paulo.pinto@automattic.com

This PR fixes issues related to saving the slack channel name in the database:

  1. Channel name was not being set by the link command
  2. Channel name was not being updated when the channel is renamed

This resulted in the channel name being displayed as UNKNOWN when issuing a link command.

Before

Screenshot 2023-07-03 at 16 25 59

After

Screenshot 2023-07-03 at 16 19 25

psrpinto added 4 commits July 3, 2023 15:21
There are other places in the codebase where SlackChannelName is set, and this is the only place where a leading # is added.
@psrpinto psrpinto requested a review from a team as a code owner July 3, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't pass "Room is now pending-name"

1 participant