Add tests for _matrix/client/v1/media/download

[H-Shay]

Pull Request Checklist

• Pull request includes a sign off

[H-Shay]

I am wondering if this error means that the tests are not running against my synapse branch and against the main branch instead?:

--2024-06-27 04:05:17--  https://github.com/element-hq/synapse/archive/shay/parse_multipart.tar.gz
Resolving github.com (github.com)... 140.82.114.3
Connecting to github.com (github.com)|140.82.114.3|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/element-hq/synapse/tar.gz/shay/parse_multipart [following]
--2024-06-27 04:05:17--  https://codeload.github.com/element-hq/synapse/tar.gz/shay/parse_multipart
Resolving codeload.github.com (codeload.github.com)... 140.82.114.10
Connecting to codeload.github.com (codeload.github.com)|140.82.114.10|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-06-27 04:05:17 ERROR 404: Not Found.


gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
--2024-06-27 04:05:17--  https://github.com/element-hq/synapse/archive/HEAD.tar.gz
Resolving github.com (github.com)... 140.82.114.3
Connecting to github.com (github.com)|140.82.114.3|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/element-hq/synapse/tar.gz/7c169f4d2ccfa7e06c6f50a08475eadd1a9202dd [following]
--2024-06-27 04:05:17--  https://codeload.github.com/element-hq/synapse/tar.gz/7c169f4d2ccfa7e06c6f50a08475eadd1a9202dd
Resolving codeload.github.com (codeload.github.com)... 140.82.114.10
Connecting to codeload.github.com (codeload.github.com)|140.82.114.10|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘STDOUT’

that would explain why the new tests are failing with 404 on the new endpoint - these do work locally so I am suspicious of this error

[S7evinK]

I am wondering if this error means that the tests are not running against my synapse branch and against the main branch instead?

Yea, CI is trying to fetch the branch from element-hq/synapse, but it looks like element-hq/synapse#17365 is from your fork.

[H-Shay]

but it looks like element-hq/synapse#17365 is from your fork.

Anything that I can do about this? I no longer have write permissions on the main repo so I think it has to come from my fork...

[H-Shay]

@S7evinK thanks for the approval - can you hit the merge button for me? I no longer have the authority to do so

[S7evinK]

ftr, Dendrite seems to be happy with my authed-media branch, except for TestMediaWithoutFileName:

    server.go:116: Server.UnexpectedRequestsAreErrors=true received unexpected request to server: GET /_matrix/federation/v1/media/download/PlainTextFile

That's due to Dendrite first attempting to fetch via the authenticated endpoint and only on failure attempts the old endpoint.