Implement managed ForwardMultidim using separable 1D FFT#1151
Open
bryancostanich wants to merge 1 commit intomathnet:masterfrom
Open
Implement managed ForwardMultidim using separable 1D FFT#1151bryancostanich wants to merge 1 commit intomathnet:masterfrom
bryancostanich wants to merge 1 commit intomathnet:masterfrom
Conversation
The managed provider now supports multi-dimensional FFT using separable 1D FFT decomposition (row-wise then column-wise). Previously these methods threw NotSupportedException, making Fourier.Forward2D() and Fourier.Inverse2D() unusable without a native provider (MKL). Fixes mathnet#1150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
ManagedFourierTransformProvider.ForwardMultidimandBackwardMultidimusing separable 1D FFT decomposition (process each dimension independently using existing 1D FFT).Previously these methods threw
NotSupportedException, makingFourier.Forward2D()andFourier.Inverse2D()unusable without a native provider (MKL).Motivation
On platforms where MKL is unavailable (macOS ARM64, other non-x86 targets), multi-dimensional FFT was completely broken. The fix is straightforward since the 1D managed FFT already works correctly.
Implementation
Tests
Added four new tests to
FourierTest.cs:All 87 FFT tests pass on both net8.0 and net48.
Fixes #1150