Skip to content

feat: implement Material 3 typography tokens and classes#120

Merged
treeder merged 15 commits into
mainfrom
feature/m3-typescale-tokens
Jul 7, 2026
Merged

feat: implement Material 3 typography tokens and classes#120
treeder merged 15 commits into
mainfrom
feature/m3-typescale-tokens

Conversation

@treeder

@treeder treeder commented Jun 25, 2026

Copy link
Copy Markdown
Member

This PR adds the M3 type scale tokens, classes, and helper styles under typography/md-typescale.js and updates md-typescale-styles.js for backward compatibility.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Material Design 3 Expressive indicators, adding a morphing geometric 'md-loading' component and extending 'md-progress' with wavy circular and linear tracks. It also refactors typography styles into a centralized 'md-typescale.js' module. Feedback focuses on optimizing animation performance by pausing the animation loop when inactive and caching DOM queries. Additionally, several robustness improvements are recommended, including preventing infinite loops from non-finite progress values, avoiding stack overflows from circular CSS variable references, ensuring SSR compatibility, and adding defensive null checks for canvas contexts.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread indicators/loading.js
Comment thread indicators/loading.js
Comment thread indicators/loading.js Outdated
Comment thread indicators/progress.js
Comment thread indicators/loading.js
Comment thread indicators/loading.js Outdated
Comment thread indicators/progress.js
Comment thread indicators/progress.js
treeder and others added 3 commits July 6, 2026 22:32
@treeder treeder merged commit 4506f0c into main Jul 7, 2026
@treeder treeder deleted the feature/m3-typescale-tokens branch July 7, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant