Skip to content

Implement mutable and immutable variables - #3800

Open
ferraridev01 wants to merge 2 commits into
mate-academy:masterfrom
ferraridev01:master
Open

Implement mutable and immutable variables#3800
ferraridev01 wants to merge 2 commits into
mate-academy:masterfrom
ferraridev01:master

Conversation

@ferraridev01

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly classifies all 8 variables into mutable and immutable categories - the core functionality is perfect. However, there's one remaining issue: the placeholder comment # write your code here still exists in app/main.py. The test_removed_comment test explicitly checks that this comment has been removed, and it will continue to fail until deleted. Simply remove those placeholder comment lines between your variable definitions and the sorted_variables dictionary. Once you delete that comment, all 27 tests will pass.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution correctly implements all requirements. The 8 variables are properly classified into mutable types (list, dict, set) and immutable types (int, float, bool, str, tuple). The sorted_variables dictionary structure matches the task specification exactly. The placeholder comment has been successfully removed. All tests should now pass.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants