Skip to content

Solution - #3794

Open
Orset1011 wants to merge 2 commits into
mate-academy:masterfrom
Orset1011:develop
Open

Solution#3794
Orset1011 wants to merge 2 commits into
mate-academy:masterfrom
Orset1011:develop

Conversation

@Orset1011

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I’m requesting changes because one unit test is failing due to a remaining scaffold comment, which is a critical blocker. Your implementation of sorted_variables is correct and all variables are categorized properly, but the test tests/test_main.py::test_removed_comment fails because the placeholder comment # write your code here is still present in app/main.py.

  • Critical issue to fix:
    • In app/main.py, remove the line containing # write your code here (likely near the top of the file). The test suite explicitly checks that this placeholder is removed.

Why this matters: The requirement is to clean up scaffold comments, and leaving it in causes a failing test that blocks completion. After removing that comment, rerun the tests; the rest of the suite already passes, so this should resolve the failure. Nice work on correctly categorizing mutable and immutable variables—once the comment is removed, your solution should be fully green.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution correctly implements all requirements. All 8 variables are properly categorized: the mutable list contains list, dict, and set, while the immutable list contains int, float, bool, string, and tuple. The placeholder comment has been successfully removed from the file. Great work on completing the task accurately!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants