Incremental change - status labels for toggle control#236
Open
smorey2 wants to merge 9 commits intomashmatrix:masterfrom
Open
Incremental change - status labels for toggle control#236smorey2 wants to merge 9 commits intomashmatrix:masterfrom
smorey2 wants to merge 9 commits intomashmatrix:masterfrom
Conversation
stomita
requested changes
Dec 5, 2017
Collaborator
stomita
left a comment
stomita
left a comment
There was a problem hiding this comment.
The snapshot files include truly generated uuids, which prevents matching previous result.
To generate snapshots with fake uuids, run
npm run test:storyshots -- -u
Author
|
I merged to upstream, and noticed the commit from "Switched to using prop-types" removed all return types in storyshots. func -> other, bool -> other. not sure why prop-types was introduced, and allowed to break stories |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #177