spec: pin resolved gap2 divergences + grammar escape note - #48
Merged
Conversation
Both impls now agree on these; pin them in the corpus:
- escaped quote in a quoted attribute value (`{title="a\"b"}` -> value a"b),
on a span and on a heading;
- an attribute-less heading brace block stays heading text (`# H {???}`);
- a footnote defined but never referenced emits no endnotes section.
Document the backslash escape in the grammar `quoted_value` production
(reusing the existing `escaped_char` rule). Re-vendor carve-lib so the
generated HTML reflects the matching carve-js changes.
Update MAINTAINING.md: move these four to a Resolved section and record the
attribute-less inline span (`[x]{}`) as an intentional divergence carve-php
keeps for DefaultAttributesExtension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the carve-js ↔ carve-php divergences that are now resolved (see carve-js #40, carve-php #31) into the conformance corpus, and updates
MAINTAINING.md.New corpus pairs
[x]{title="a\"b"}and# H {title="a\"b"}→ valuea"b(title="a"b"). A backslash escapes ASCII punctuation in a quoted value.# H {???}→<h1>H {???}</h1>(grammarattribute_listneeds ≥ 1 attribute, so it's heading text, not dropped).text\n[^f]: note→<p>text</p>(no endnotes section).Grammar
quoted_valuenow documents the backslash escape, reusing the existingescaped_charrule.MAINTAINING.md
The four resolved divergences (the three above + mention URL encoding/placeholder) move to a Resolved section. The attribute-less inline span (
[x]{}→<span>) is recorded as an intentional carve-php divergence (itsDefaultAttributesExtensiondecorates spans post-parse).carve-lib re-vendored. Conformance: 153/153.