fix: withdraw the quote attribution, a captioned quote is a figure again - #984
Merged
Conversation
markup-carve/carve#1213 withdraws PART 9 §4a and PART 11 §10d. A caption on a block quote is not an attribution; it is a caption like any other, so a captioned quote is a `figure` whose target is the quote - the shape this engine produced before #946. WHY THE CLAUSE FELL. The HTML Standard's `blockquote` section requires that "attribution for the quotation, if any, must be placed outside the `blockquote` element", and gives a `<figure>` wrapping the quote with a `<figcaption>` as the way to attach it, "which is not part of the quote and therefore doesn't belong inside the `blockquote` itself". §4a put it inside, in a `<footer>`, and asserted that both spellings were valid. Its model argument fails too: `figure` is already the generic captioned wrapper, since a captioned code block is a `figure` whose target is the code block, and what a captioned thing is called and counted as comes from the caption's own label rather than the host's node type. Nothing had shipped - 0.1.2 predates the port - so this removes code no release carried, and the CHANGELOG loses those entries rather than gaining a reversal. WHAT COMES BACK: `> To be` + `^ Hamlet` renders <figure> <blockquote><p>To be</p></blockquote> <figcaption>Hamlet</figcaption> </figure> The caption numbers like any other and shares the Figure bucket with images, so a numbered cross-reference to the quote's id resolves again. `BlockQuote.attribution` is gone from the node, from the AST JSON codec and from every walk, extension and renderer that carried it, and `FigureTarget::BlockQuote` is back. `src/wire_fields.rs` is regenerated from the moved spec submodule rather than hand-edited. A `<footer>` inside a quote is ordinary quoted content again on the import path. The Markdown, plain-text and terminal renderers lose the attribution-specific handling §10d added and render a quote's caption the way they render any other figure caption. WHAT STAYS. PART 11 §10e landed in the same commits and is untouched: a table caption still survives the Markdown target, and a code fence's title and grouping label still survive plain text and the terminal. Measured against carve-js on the same branch: the HTML, Markdown, plain-text and terminal output for a captioned quote is byte-identical in both engines, and a numbered caption resolves to the same "Figure 1" cross-reference.
dereuromark
marked this pull request as ready for review
August 15, 2026 01:43
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A caption on a block quote is a figure caption again.
block_quote.attributionis gone,figure.targetadmits ablock_quote, and the spec submodule moves onto the withdrawal.Implements markup-carve/carve#1213, which withdraws PART 9 section 4a and PART 11 section 10d.
Why the clause fell
The HTML Standard's
blockquotesection:and its recommended pattern, given as the way "to clearly relate a quote to its attribution (which is not part of the quote and therefore doesn't belong inside the
blockquoteitself)":Section 4a put the attribution inside the quote, in a
<footer>, and asserted in its own text that both spellings were valid HTML.Its model argument fails too.
figureis already the generic captioned wrapper in this engine: a captioned code block is afigurewhose target is the code block. What a captioned thing is called and counted as comes from the caption's own label, not from the host's node type, so a quote was never a special host.Nothing shipped. 0.1.2 predates #946, so this removes code no release carried, and the CHANGELOG loses those entries rather than gaining a reversal.
What comes back
The caption numbers like any other. Measured on this branch:
BlockQuote.attributionis gone from the node, the AST JSON codec and every walk, extension and renderer that carried it, andFigureTarget::BlockQuoteis back.src/wire_fields.rsis regenerated from the moved spec submodule rather than hand-edited.<footer>inside a quote is ordinary quoted content again on the import path.<footer>element, the quote bar carried onto the attribution line, the removed blank line) and render a quote's caption the way they render any other figure caption.What stays
PART 11 section 10e landed in the same commits and is untouched: a table caption still survives the Markdown target, and a code fence's title and grouping label still survive plain text and the terminal. Measured on this branch:
Multi-block captioned quotes also keep working. The pre-4a oracle refused them; that regression does not come back.
Cross-engine
Measured against carve-js on its matching branch: the HTML, Markdown, plain-text and terminal output for a captioned quote is byte-identical in both engines, and a numbered caption resolves to the same "Figure 1" cross-reference.
Downstream
markup-carve/carve-js and markup-carve/carve-php get the same revert. markup-carve/carve-grammars#219 tracks the tiptap projection.