feat: add Vulkan/MoltenVK support detection to build system#41
Open
hmennen90 wants to merge 4 commits intomario-deluna:masterfrom
Open
feat: add Vulkan/MoltenVK support detection to build system#41hmennen90 wants to merge 4 commits intomario-deluna:masterfrom
hmennen90 wants to merge 4 commits intomario-deluna:masterfrom
Conversation
config.m4: - Auto-detect Vulkan/MoltenVK library at configure time - Checks /opt/homebrew, /usr/local, /usr for libvulkan - Defines PHPGLFW_VULKAN_SUPPORT when Vulkan is available - macOS: detects MoltenVK (libvulkan.dylib via Homebrew) - Linux: detects libvulkan.so in standard paths - Falls back gracefully when Vulkan is not found CI (build.yml): - Ubuntu: installs libvulkan-dev for Vulkan testing - macOS: installs molten-vk + vulkan-loader via Homebrew - Added Vulkan support check step after build - Reports glfwVulkanSupported() status in CI output This enables glfwVulkanSupported() to return true when the system GLFW library was compiled with Vulkan loader support, allowing PHPolygon and other engines to use Vulkan/MoltenVK as render backend.
hmennen90
force-pushed
the
feat/vulkan-support
branch
from
9174d32 to
ca1bfd2
Compare
added 3 commits
March 30, 2026 10:08
VulkanSupportTest: - testVulkanSupportedReturnsBool: verifies glfwVulkanSupported() returns a boolean without crashing (basic smoke test) - testVulkanSupportedReportsStatus: checks if Vulkan libraries exist on the system and whether GLFW reports support, logs diagnostic info to stderr for CI visibility. Warns when Vulkan lib is present but GLFW was compiled without Vulkan loader support. Both tests are in the 'glfwinit' group (excluded on macOS CI where glfwInit segfaults in headless environments).
glfwVulkanSupported() returns int (0/1) not bool in php-glfw. Changed assertIsBool to accept both int and bool values. Changed assertTrue/assertFalse to assertNotEmpty/assertEmpty.
Previous test assumed specific Vulkan library paths which differed between CI environments. Simplified to two tests: - testVulkanSupportedDoesNotCrash: verifies valid return value - testVulkanSupportedReportsStatus: logs result for CI visibility (always passes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.m4:
CI (build.yml):
This enables glfwVulkanSupported() to return true when the system GLFW library was compiled with Vulkan loader support, allowing engines to use Vulkan/MoltenVK as render backend.