RelativeVirtualAddress deprecation#3090
Open
corkamig wants to merge 8 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates the RelativeVirtualAddress class by raising a DeprecationWarning upon instantiation, and adds a corresponding test and changelog entry. The feedback suggests using pytest.warns instead of modifying global warning filters in the test suite to prevent interference with other tests.
williballenthin
requested changes
May 29, 2026
Collaborator
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
looks good, please just update the warning text with more context.
williballenthin
requested changes
Jun 1, 2026
| """a memory address relative to a base address""" | ||
|
|
||
| def __new__(cls, *args, **kwargs): | ||
| # TODO(corkamig): Removal for v3.5.0 |
Collaborator
There was a problem hiding this comment.
we're currently at v9.4.0 for capa, so i think we should delete the code either in v10 or v11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3072
Checklist