Correct NumPy version in CONTRIBUTING.md CI note - #1347
Open
moylstmed360 wants to merge 2 commits into
Open
Conversation
moylstmed360
assigned
moylstmed360 and
jonbrenas and unassigned
jonbrenas and
moylstmed360
Collaborator
|
It looks like the tests ran without any issue. |
jonbrenas
requested changes
Sep 1, 2026
jonbrenas
left a comment
jonbrenas
left a comment
Collaborator
There was a problem hiding this comment.
I guess it would more accurate to describe each test that needs to pass.
Collaborator
Author
|
Thanks Jon, that's fair. Updated to describe all eight required checks rather than picking one example. Let me know if you'd word it differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md stated that CI tests run on Python 3.10 with NumPy 1.26.4. The Matrix in test.yml pins numpy >= 2.0.2 < 2.1, so the note was out of date. Also opened as a second PR while still a first-time contributor, to test whether the workflow approval issue Jon hit on #1346 recurs.