Prevent deprecation errors in PHP 8.4

[lvanstrijland]

Hi,

I created this PR to make sure we prevent deprecation warning for PHP 8.4 because of the explicit nullable type.

Kind Regards,
Laurens van Strijland

Note: This repository is auto-generated, and does not accept pull requests.

To make changes or open issues for this SDK, use the code generation repository.

[benjamenjohnsondev]

any updates on this? We're currently running php 8.x override patches

[Corys8646]

I submitted a support ticket and got a generic response. I also made a post in r/MailChimp on Reddit, which they seem to participate in actively. Hopefully, this will get merged soon.

[marc31]

@lvanstrijland and you clean their sdk too

[BrianVB]

Would be nice to have this pulled in along with fixes for the deprecation warnings in this file:

https://github.com/mailchimp/mailchimp-marketing-php/blob/master/lib/Configuration.php

Creation of dynamic property MailchimpMarketing\ApiClient::$accountExport is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::70
Creation of dynamic property MailchimpMarketing\ApiClient::$accountExports is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::71
Creation of dynamic property MailchimpMarketing\ApiClient::$activityFeed is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::72
Creation of dynamic property MailchimpMarketing\ApiClient::$authorizedApps is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::73
Creation of dynamic property MailchimpMarketing\ApiClient::$automations is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::74
Creation of dynamic property MailchimpMarketing\ApiClient::$batchWebhooks is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::75
Creation of dynamic property MailchimpMarketing\ApiClient::$batches is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::76
Creation of dynamic property MailchimpMarketing\ApiClient::$campaignFolders is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::77
Creation of dynamic property MailchimpMarketing\ApiClient::$campaigns is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::78
Creation of dynamic property MailchimpMarketing\ApiClient::$connectedSites is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::79
Creation of dynamic property MailchimpMarketing\ApiClient::$conversations is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::80
Creation of dynamic property MailchimpMarketing\ApiClient::$customerJourneys is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::81
Creation of dynamic property MailchimpMarketing\ApiClient::$ecommerce is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::82
Creation of dynamic property MailchimpMarketing\ApiClient::$facebookAds is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::83
Creation of dynamic property MailchimpMarketing\ApiClient::$fileManager is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::84
Creation of dynamic property MailchimpMarketing\ApiClient::$landingPages is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::85
Creation of dynamic property MailchimpMarketing\ApiClient::$lists is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::86
Creation of dynamic property MailchimpMarketing\ApiClient::$ping is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::87
Creation of dynamic property MailchimpMarketing\ApiClient::$reporting is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::88
Creation of dynamic property MailchimpMarketing\ApiClient::$reports is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::89
Creation of dynamic property MailchimpMarketing\ApiClient::$root is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::90
Creation of dynamic property MailchimpMarketing\ApiClient::$searchCampaigns is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::91
Creation of dynamic property MailchimpMarketing\ApiClient::$searchMembers is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::92
Creation of dynamic property MailchimpMarketing\ApiClient::$Surveys is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::93
Creation of dynamic property MailchimpMarketing\ApiClient::$templateFolders is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::94
Creation of dynamic property MailchimpMarketing\ApiClient::$templates is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::95
Creation of dynamic property MailchimpMarketing\ApiClient::$verifiedDomains is deprecated /[...]/vendor/mailchimp/marketing/lib/Configuration.php::96

[chelipineda]

I've just talk to mailchimp official support and this is their answer.

_Bueno, lo único que sé es que eso no lo gestionamos nosotros, sino GitHub. Ese fue el enlace que me proporcionaron para que pudieras crear un reporte de problema. Eso es todo lo que sabemos.

Parece que contrataron a un experto en MC o se pusieron en contacto con un desarrollador. Les sugiero que vuelvan a contactarlos, ya que esto no entra dentro de nuestro alcance de soporte técnico.

Basically they're saying they have nothing to do with this. Good luck with that

We're going to use another solution. Mailchimp support is really a mess

[valenzine]

I've just talk to mailchimp official support and this is their answer.

_Bueno, lo único que sé es que eso no lo gestionamos nosotros, sino GitHub. Ese fue el enlace que me proporcionaron para que pudieras crear un reporte de problema. Eso es todo lo que sabemos.

Parece que contrataron a un experto en MC o se pusieron en contacto con un desarrollador. Les sugiero que vuelvan a contactarlos, ya que esto no entra dentro de nuestro alcance de soporte técnico.

Basically they're saying they have nothing to do with this. Good luck with that

We're going to use another solution. Mailchimp support is really a mess

The idea that GitHub itself manages their PHP SDK is so absurd I wonder if this person actually understands what it means.

[marc31]

We’re also going to stop using Mailchimp, as the lack of maintenance of their SDK is unacceptable.

[damienalexandre]

Looks like this SDK does not accepts PR, and we must do it in https://github.com/mailchimp/mailchimp-client-lib-codegen instead.

https://github.com/mailchimp/mailchimp-client-lib-codegen/tree/main/swagger-config/marketing/php

It's just a https://github.com/swagger-api/swagger-codegen based client. So I guess I'm going to ditch this and use JanePHP instead https://jane.readthedocs.io - it's great to build API clients based on spec: https://github.com/mailchimp/mailchimp-client-lib-codegen/blob/main/spec/transactional.openapi.json