Skip to content

⚡ perf: memoize attribute options in Swatches Helper#40736

Open
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
lbajsarowicz:perf/swatches-memoize-options
Open

⚡ perf: memoize attribute options in Swatches Helper#40736
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
lbajsarowicz:perf/swatches-memoize-options

Conversation

@lbajsarowicz
Copy link
Copy Markdown
Contributor

Summary

  • Cache getAllOptions() results by attribute ID + store ID in Swatches\Helper\Data to avoid redundant source model lookups when processing multiple swatch attributes.
  • Cache key includes store ID to prevent cross-store label pollution in multi-store setups.

Performance Impact

Metric Before After
getAllOptions() calls 1× per attribute per invocation 1× per attribute+store combination (cached)
Multi-store safety N/A Cache keyed by attributeId_storeId

Test Plan

  • Unit test verifies getAllOptions() called once per attribute (memoization works)
  • Cache key includes store ID for multi-store correctness
  • PHPCS clean (requires CI)
  • PHPStan clean (requires CI)

Ref: #40725

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

Cache getAllOptions() results by attribute ID to avoid redundant
source model lookups when processing multiple swatch attributes.

Ref: magento#40725
Prevent cross-store cache pollution in multi-store setups where
option labels differ by store.
@m2-assistant
Copy link
Copy Markdown

m2-assistant bot commented Apr 13, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Copy Markdown
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant