Skip to content

⚡ perf: memoize hasSingleStore() in StoreManager#40732

Open
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
lbajsarowicz:perf/store-memoize-has-single-store
Open

⚡ perf: memoize hasSingleStore() in StoreManager#40732
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
lbajsarowicz:perf/store-memoize-has-single-store

Conversation

@lbajsarowicz
Copy link
Copy Markdown
Contributor

Summary

  • Memoize hasSingleStore() result in StoreManager to avoid redundant store collection loading on every call.
  • The method previously called getStores(true) and counted results on every invocation. The code contained a TODO (MAGETWO-39902) acknowledging the need for caching.
  • Cache is properly invalidated in reinitStores() and _resetState().

Performance Impact

Metric Before After
hasSingleStore() Calls getStores(true) + count on every invocation Single computation, cached in instance property
Cache invalidation N/A Reset on reinitStores() and _resetState()

Test Plan

  • Unit test verifies memoization (repeated calls don't re-execute getList())
  • Unit test verifies cache invalidation after reinitStores()
  • Unit test verifies re-memoization after invalidation (two calls post-reinit, only one getList())
  • PHPCS clean (requires CI validation)
  • PHPStan clean (requires CI validation)

Ref: #40706

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Apr 13, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Avoid redundant store collection loading on every hasSingleStore() call.
The result is now cached in an instance property and reset on reinitialize().

Ref: magento#40706
Add second call after reinit to verify re-memoization. Clarify docblock.
@lbajsarowicz lbajsarowicz force-pushed the perf/store-memoize-has-single-store branch from 02b2e66 to bf35ae1 Compare April 13, 2026 21:24
@lbajsarowicz
Copy link
Copy Markdown
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

2 participants