fix: remove dead openssl_free_key() code path in JwkFactory

[lbajsarowicz]

Description

Remove the dead openssl_free_key() code path from JwkFactory::freeResource().

Problem

The freeResource() method contains a version check that is always false:

if (\is_resource($resource) && (version_compare(PHP_VERSION, '8.0') < 0)) {
    openssl_free_key($resource);
}

Since Magento requires PHP 8.3+, this condition can never be true. In PHP 8.0+, OpenSSL key resources were replaced with OpenSSLAsymmetricKey objects that are automatically freed by garbage collection, and openssl_free_key() was deprecated (removed in 8.5).

Solution

Remove the dead code path from the method body. The method signature is preserved since it is called from within the class.

Files Changed

• lib/internal/Magento/Framework/Jwt/JwkFactory.php

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

Resolved issues:

1. resolves [Issue] fix: remove dead openssl_free_key() code path in JwkFactory #40761: fix: remove dead openssl_free_key() code path in JwkFactory

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[lbajsarowicz]

@magento run all tests

[engcom-Dash]

@magento create issue