Skip to content

Force reload parent product in LinkManagement::addChild() to avoid stale cache #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddevallan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Force reload parent product in LinkManagement::addChild() to avoid stale cache #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/ConfigurableProduct/Model/LinkManagement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public function getMediaEntries(array $images): array
*/
public function addChild($sku, $childSku)
{
$product = $this->productRepository->get($sku, true);
$product = $this->productRepository->get($sku, true, null, true);
$child = $this->productRepository->get($childSku);

$childrenIds = array_values($this->configurableType->getChildrenIds($product->getId())[0]);
Expand Down
36 changes: 36 additions & 0 deletions app/code/Magento/ConfigurableProduct/Test/Unit/Model/LinkManagementTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,42 @@ public function testAddChild(): void
$this->assertTrue($this->object->addChild($productSku, $childSku));
}

public function testAddChildLoadsParentWithForceReload(): void
{
$productSku = 'configurable-sku';
$childSku = 'simple-sku';

$configurable = $this->createMock(Product::class);
$configurable->method('getId')->willReturn(666);
$simple = $this->createMock(Product::class);
$simple->method('getId')->willReturn(1);

// Assert that the parent is loaded with forceReload=true (4th argument)
// to bypass the in-memory cache. This prevents stale data from being used
// in long-lived processes such as queue consumers.
$this->productRepository
->expects($this->atLeastOnce())
->method('get')
->willReturnCallback(
function ($sku, $editMode = false, $storeId = null, $forceReload = false)
use ($productSku, $childSku, $configurable, $simple) {

@marcelmtz marcelmtz Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a phpcs issue on this line, I can fix it during the next week, but just mentioning if you have a chance before.

if ($sku === $productSku) {
$this->assertTrue($forceReload, 'Parent product must be loaded with forceReload=true');
return $configurable;
}
return $simple;
}
);

$this->configurableType->method('getChildrenIds')
->willReturn([0 => [1, 2, 3]]);

// Child ID 1 is already in the list → StateException expected
$this->expectException(\Magento\Framework\Exception\StateException::class);
$this->expectExceptionMessage('The product is already attached.');
$this->object->addChild($productSku, $childSku);
}

/**
* @return void
*/
Expand Down
Loading