tests(e2e): vendor Elgentos Playwright E2E test suite - #199
tests(e2e): vendor Elgentos Playwright E2E test suite#199digitalrisedorset wants to merge 6 commits into
Conversation
Add the Elgentos Playwright E2E test suite under dev/tests/e2e, including base-tests and concrete Mage-OS tests, preserving the upstream inheritance model. This provides a complete, runnable E2E test setup for Mage-OS without introducing CI enforcement.
|
Thanks Herve. Not having looked to compare yet, how close of a match is this to the Elgentos suite? |
Hi Ryan, I copy the PR i made to Elgentos' team for you to see the differences. elgentos/magento2-playwright#209 (comment) |
| PLAYWRIGHT_BASE_URL=https://hyva-demo.elgentos.io/ | ||
| PLAYWRIGHT_PRODUCTION_URL=https://hyva-demo.elgentos.io/ | ||
| PLAYWRIGHT_REVIEW_URL=https://hyva-demo.elgentos.io/ | ||
|
|
There was a problem hiding this comment.
this file (renamed to .env) is required to run the e2e test suite: the data should point to the test Magento url. I do not know what this url is?
Assuming the demo url may be https://mageos.demo.co.uk/, the below is a possible content:
PLAYWRIGHT_BASE_URL=https://mageos.demo.co.uk/
PLAYWRIGHT_PRODUCTION_URL=https://mageos.demo.co.uk/
PLAYWRIGHT_REVIEW_URL=
MAGENTO_ADMIN_SLUG=admin
MAGENTO_ADMIN_USERNAME=admin
MAGENTO_ADMIN_PASSWORD=P1ssw0rd
MAGENTO_THEME_LOCALE=en_US
MAGENTO_NEW_ACCOUNT_PASSWORD=NewTest1234!
MAGENTO_EXISTING_ACCOUNT_EMAIL_CHROMIUM=test-user@magsite.co.uk
MAGENTO_EXISTING_ACCOUNT_EMAIL_FIREFOX=test-user@magsite.co.uk
MAGENTO_EXISTING_ACCOUNT_EMAIL_WEBKIT=test-user@magsite.co.uk
MAGENTO_EXISTING_ACCOUNT_PASSWORD=TestPassword123!
MAGENTO_EXISTING_ACCOUNT_CHANGED_PASSWORD=Test2Password123!
MAGENTO_COUPON_CODE_CHROMIUM=H20
MAGENTO_COUPON_CODE_FIREFOX=H20
MAGENTO_COUPON_CODE_WEBKIT=H20
There was a problem hiding this comment.
We'll need something to integrate it with the github-action at https://github.com/mage-os/github-actions/pull/313/changes -- the action should provide the access URL to the instance or test runner. CC @michielgerritsen
|
@rhoerr @digitalrisedorset what I can do to help moving this forward? should we run some tests? is there any configuration missing? happy to jump into action |
Hi @marcelmtz merging this code would go a long way for me. However, until we are clear with how it gets linked to @damienwebdev orchestrator, it is premature to send it to MageOS. The discussion we had today regarding the security concerns when using npm can explain why it takes more time than anticipated to move this PR. |
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "name": "@elgentos/magento2-playwright", | |||
There was a problem hiding this comment.
should we rename the package to avoid any possible conflicts?
4 participants
This PR adds a browser-based Playwright E2E test suite under
dev/tests/e2efor Mage-OS (Hyvä), preserving the upstream Elgentos inheritance model and providing runnable user-journey tests without introducing CI enforcement.Description (*)
This PR adds the Elgentos Playwright End-to-End (E2E) test suite under
dev/tests/e2e,adapted for Mage-OS and the Hyvä storefront.
The suite includes both the shared
base-testsand Mage-OS–specific tests,preserving the upstream inheritance and extension model used by Elgentos.
The result is a complete, runnable, browser-based E2E test setup for Mage-OS
that validates real user journeys against a live storefront.
This change is intentionally additive and does not introduce CI enforcement.
Related Pull Requests
N/A
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
dev/tests/e2eQuestions or comments
N/A
Contribution checklist (*)