fix: prevent signed integer overflow in gzseek64 for SEEK_SET#1227
Open
SongTonyLi wants to merge 1 commit into
Open
fix: prevent signed integer overflow in gzseek64 for SEEK_SET#1227SongTonyLi wants to merge 1 commit into
SongTonyLi wants to merge 1 commit into
Conversation
Reject negative offsets early in the SEEK_SET branch of gzseek64() before subtracting state->x.pos. Previously, passing INT64_MIN as the offset with a non-zero stream position caused undefined behavior via signed overflow (offset -= state->x.pos overflows z_off64_t). Negative absolute positions are always invalid for SEEK_SET, so returning -1 immediately is both safe and semantically correct. Fixes madler#1222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1222. Generally agree with the issue's suggested fix, and I independently verified the patch's validity.
gzseek64()unconditionally subtractsstate->x.posfrom the user-supplied offset whenwhence == SEEK_SET. IfoffsetisINT64_MINand the stream position is non-zero, this overflows the signedz_off64_ttype — undefined behavior flagged by UBSan.Since a negative absolute position is always invalid for
SEEK_SET, this patch rejects it early (returns-1) before the subtraction, eliminating the overflow without changing observable semantics.Fix
Add
if (offset < 0) return -1;guard inside theSEEK_SETbranch, beforeoffset -= state->x.pos.Verification
Tested with UBSan-instrumented build:
gzlib.c:389:16: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'off64_t'Reproducer: