Fix Makefile.msc for ARM64 Windows#1224
Open
BraveChicken1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Windows ARM64 build with Microsoft Visual C++.
On ARM64 the
-base:0x5A4C0000flag is not allowed, it gives the following error:fatal error LNK1355: invalid base address 0x5A4C0000; ARM64 image cannot have base address below 4GB.This PR introduces a new optional variables
ARCHin the Makefile.msc. When the option is equal toarm64the base flag is omitted. When the variable is not passed to the makefile, the behaviour remains the same as before, ensuring full backwards compatibility.