Record SNOS timing in job metadata - #1194
Conversation
|
Triggered manual Orchestrator Docker image build for this branch: https://github.com/madara-alliance/madara/actions/runs/28082160388 Expected image tag after successful publish: |
Confidence Score: 4/5Safe to merge; changes are additive and isolated to SNOS job metadata, with no behavioral changes to the processing path itself. The only finding is a pre-existing inconsistency:
Reviews (1): Last reviewed commit: "Record SNOS timing in job metadata" | Re-trigger Greptile |
| /// SNOS total steps taken | ||
| pub snos_n_steps: Option<usize>, |
There was a problem hiding this comment.
snos_n_steps missing #[serde(default)]
The existing snos_n_steps: Option<usize> field (added in a prior PR) has no #[serde(default)] annotation, while the three new timing fields added here correctly do. Without #[serde(default)], serde will return a "missing field" error when deserializing any persisted SNOS job record that was created before snos_n_steps was introduced — same class of backward-compat issue the new fields guard against. Worth adding it here while the struct is being touched.
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
Summary
Notes
Testing