Repository navigation
fix(icons): stop the agent sparkle from turning - #9025
Merged
Merged
Conversation
Why: the new-conversation greeting's Macro logo rocked and the heading flipped in on every mount and Chat/Code switch, which read as shaking. What: drop the greeting-mark-wave and greeting-flip animations and the keyed remount that retriggered the flip; the logo cross-fade stays. Co-authored-by: gbirman <gbirman@users.noreply.github.com>
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title uses the conventional commits format with the fix: prefix, describes the animation removal, and is 54 characters long, below the 72-character limit. |
| Description check | |
The description clearly explains the removed logo and text animations, the NewChatPage rendering change, and the unchanged logo cross-fade. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Why: the Agents navigation icon rotated on hover and press, so the rail appeared to shake whenever the pointer crossed it. What: drop sparkle from hover motion and from the rotating glyphs; it keeps the shared press-and-settle scale. Update the icon README. Co-authored-by: gbirman <gbirman@users.noreply.github.com>
cursor
Bot
changed the title
This reverts commit d82e634. Co-authored-by: gbirman <gbirman@users.noreply.github.com>
This reverts commit e073831. Co-authored-by: gbirman <gbirman@users.noreply.github.com>
Why: the Agents sparkle in the outer navigation rail rotated on hover and press, which read as the rail shaking. What: opt the Agents rail button out of shared icon motion with data-icon-motion="none"; other rail items and sparkle glyphs elsewhere keep their motion. Co-authored-by: gbirman <gbirman@users.noreply.github.com>
cursor
Bot
changed the title
cursor
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shared icon motion singled out the sparkle glyph: it was the only navigation rail icon with hover motion, and it rotated 8° on hover and 15° on press. The Agents icon in the outer rail looked like it was shaking.
What
icon-motion.ts: removesparklefrom the hover glyphs and from the rotating glyphs. It keeps the shared press-and-settle scale that the other rail icons use.