Skip to content

feat(auth): accept Gmail in mobile email capture - #9023

Merged
jbecke merged 2 commits into
mainfrom
jacob/mobile-capture-allow-gmail
Oct 28, 2026
Merged

jbecke merged 2 commits into
mainfrom
jacob/mobile-capture-allow-gmail

Conversation

@jbecke

@jbecke jbecke commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Why

The site's mobile email capture rejected every consumer address, so
Gmail users could not get the "continue on desktop" link even though
Macro supports Gmail inboxes.

What

  • services/authentication_service/src/api/mobile_welcome_email.rs:
    exempt gmail.com and googlemail.com from the personal-email check on
    /mobile-welcome-email. Other generic providers (iCloud, Yahoo, …) are
    still rejected. The 400 message becomes "Please use your work email or
    Gmail".
  • apps/marketing: the capture field's placeholder now reads "Your work
    email or Gmail", and WORK_EMAIL_REQUIRED matches the new server message.
  • FormMobileSignup.tsx is reformatted with Biome in a separate commit; it
    already failed formatting on main, and CI lints touched files.

The auth service should deploy with or before the site, so the site does
not invite Gmail addresses the server still rejects.


Generated by Claude Code

Why: the website's mobile email capture rejected every consumer address,
turning away Gmail users, whose inboxes Macro supports.

What: exempt gmail.com and googlemail.com from the personal-email check on
/mobile-welcome-email, and update the site's placeholder and error copy to
ask for a work email or Gmail.
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d05f22e and 81d9d87.

Files selected for processing: 3
  • apps/marketing/src/app/components/forms/FormMobileSignup.tsx
  • apps/marketing/src/app/utils/utilMobileSignup.ts
  • services/authentication_service/src/api/mobile_welcome_email.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Mobile signup now accepts Gmail addresses alongside work email addresses.
  • Bug Fixes
    • Updated the email field placeholder and validation message to clarify that Gmail can be used.
    • Other personal email providers, including Yahoo and iCloud, remain unsupported.

The authentication service now accepts Gmail and Googlemail addresses while continuing to classify other generic email domains as personal. Its error message, the signup form placeholder, and the signup error message now refer to work email or Gmail. Tests cover Gmail and Googlemail acceptance, including mixed-case and whitespace-padded Gmail, and rejection of iCloud and Yahoo addresses.

Priority: Normal

Merge Risk: Minimal · up to 81d9d

The Gmail signup behavior and user-facing messaging are consistent across the flow, with no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title uses the conventional commits format, describes the Gmail authentication change, and is 48 characters long.
Description check Passed The description clearly explains the Gmail acceptance change, the continued rejection of other consumer providers, the matching marketing copy updates, and the deployment dependency.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jbecke
jbecke merged commit 9527249 into main Oct 28, 2026
29 checks passed
@jbecke
jbecke deleted the jacob/mobile-capture-allow-gmail branch October 28, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants