Repository navigation
ci: fail pull requests whose text carries personal or support details - #8891
Merged
Merged
Conversation
Why: PR titles, bodies, and commit messages are public, and recent ones included contact details and links to support conversations. A check catches what a pattern can see before review. What: a PR Privacy Check workflow, generated from xtask_workflows, scans the PR title, body, and commit messages for emails, phone numbers, @mentions, chat-channel names, and support-tool or workspace item links. It re-runs on edits and skips Dependabot. `just pr-privacy` runs the same script locally.
Why: agents wrote people, customers, and support channels into PR descriptions as evidence. Pull request text should describe only the code, with any reason stated in general terms. What: a Privacy section in the git skill, a guardrail in CLAUDE.md, an audit check that runs `just pr-privacy`, and the same note for human contributors in CONTRIBUTING.md.
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR titles, bodies, and commit messages are public, and recent ones carried
personal contact details and links into support conversations. Agents also
followed the PR template's prompt to describe "the user request", which pulls
requesters and channels into the description. Pull request text should
describe the code change only, with any reason stated in general terms.
How it works
Mentions and channel names are only matched outside code spans and fences,
where decorators, CSS colors, and shell comments look alike. Emails, phone
numbers, and links are matched everywhere. Names of people and customers
can't be matched by a pattern; the docs and reviewers cover those.
What
tooling/xtask/crates/xtask_workflows: newpr_privacy_checkworkflowmodule and its script, generated to
.github/workflows/pr-privacy-check.yml.Title and body reach the script through env vars; commits come from the PR
API, so there is no checkout. It runs on
edited, so fixing the descriptionclears it.
just pr-privacy [body-file]runs the same script on the branch's commitsand, with
PR_TITLEset, a draft title and body..agents/skills/git/SKILL.md: a Privacy section covering what never goesinto PR text, commits, comments, docs, or fixtures, with how to phrase the
reason instead. The PR template's Why no longer asks for the user request.
CLAUDE.md: a one-line guardrail pointing at the Privacy section..agents/skills/audit/SKILL.md: the audit runsjust pr-privacyandrereads PR text against the Privacy section.
CONTRIBUTING.md: the same rule for human contributors.Follow-ups
PR Privacy Checkas a required status check in branch protection;until then it reports but does not block merging.
Generated by Claude Code