Repository navigation
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
synoet
force-pushed
the
synoet/email-scroll-anchor
branch
from
October 17, 2026 12:43
4b1d31d to
be0f7f1
Compare
synoet
force-pushed
the
synoet/email-stable-row-ids
branch
from
October 17, 2026 12:43
c35a65b to
40103cd
Compare
Why: email rows were identified by thread and date group. When a reply arrived on a thread from yesterday, or its reminder returned, it moved to Today under a new row id: the row remounted, the keyboard cursor on it vanished and fell back to a neighbouring thread, and with the reading pane open the pane followed that fallback and switched away from the thread being read. What: grouped soup rows can be keyed by entity alone, for lists where each entity sits in one group; the email list's date buckets use it. A thread changing group keeps its row, its DOM and the cursor. An entity listed in two groups still gets two rows.
synoet
force-pushed
the
synoet/email-stable-row-ids
branch
from
October 17, 2026 12:56
40103cd to
69e446e
Compare
synoet
force-pushed
the
synoet/email-scroll-anchor
branch
from
October 17, 2026 12:56
be0f7f1 to
47575b3
Compare
Contributor
Author
|
Consolidated into #8247 with the other list stability fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8245 (email list stability).
Why
Email rows were identified by thread and date group. When a reply arrived on a thread from yesterday, or its reminder returned, it moved to Today under a new row id: the row remounted, the keyboard cursor on it vanished and fell back to a neighbouring thread, and with the reading pane open the pane followed that fallback and switched away from the thread being read.
What
features/soup/collection/rows.ts:buildGroupedSoupRows(groups, { keyByEntity: true })leaves the group out of entity row ids, for lists where each entity sits in one group; an entity listed in two groups still gets two rows.Verified by injecting a reply on the thread under the cursor with the reading pane open: the thread moves to Today, keeps its DOM element and the cursor, and the pane stays on it.