Repository navigation
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
synoet
force-pushed
the
synoet/soup-keep-pages-on-refresh
branch
from
October 17, 2026 12:43
f509dfa to
77fd288
Compare
synoet
force-pushed
the
synoet/email-mail-list-depth
branch
from
October 17, 2026 12:43
97e3a13 to
39d28eb
Compare
Why: every email tab shows the local cache's Mail page once the cache changes after the network page landed, and the mail backfill, thread loads and read marks change it every few seconds. Each change evaluated the page at its first 100 rows, so a list scrolled past them collapsed back. Loading more failed too: the backfill moved the page's cursor before the next page arrived, the page was dropped, and Load More did nothing, so no tab could show more than 100 threads. What: the local Mail page remembers its depth, the rows loaded through either source, and every evaluation reads that deep, following the index's cursor in requests the cache accepts (fewer than 500 rows each). A next page whose cursor went stale raises the depth and evaluates again instead of dropping back to the first page. Loading more also advances the server pages, so the list stays as deep when the network page is authoritative again.
synoet
force-pushed
the
synoet/soup-keep-pages-on-refresh
branch
from
October 17, 2026 12:56
77fd288 to
fc29458
Compare
synoet
force-pushed
the
synoet/email-mail-list-depth
branch
from
October 17, 2026 12:56
39d28eb to
968e615
Compare
Contributor
Author
|
Consolidated into #8247 with the other list stability fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8243 (email list stability).
Why
Every email tab shows the local cache's Mail page once the cache changes after the network page landed, and the mail backfill, thread loads and read marks change it every few seconds. Each change evaluated the page at its first 100 rows, so a list scrolled past them collapsed back. Loading more failed too: the backfill moved the page's cursor before the next page arrived, the page was dropped and re-evaluated at 100 rows, and Load More did nothing. No tab could show more than 100 threads while the cache was busy.
How it works
What
create-soup-live-query.ts:localMailDepth; stale-cursor and stale-revision paths deepen instead of dropping to the first page.graphql_cache.soup_local_evaluationrecordsevaluation.depthandevaluation.depth_requests.mail-depth.ts:readMailDepth, a bounded cursor walk that stops at a revision change, an empty page or a repeated cursor.mail-depth.test.tscovers each stop condition and the per-request limit;items.test.tschecks a paged Mail list stays as deep across a cache write, and paging still works when a write stales the cursor, and a Load More reads only the page it asked for.docs/local-predicate-pagination-plan.mddescribes the new revision behavior.Verified on a seeded inbox: Signal and All page past 100 threads while the backfill runs, and marking a thread done 260 rows down removes one row without moving the viewport.