Enable ZIHPM unpriviledged performance counters#29
Open
SamuelRiedel wants to merge 1 commit into
Open
Conversation
By now, we support those performance counters in Ibex so we enable them again.
3 tasks
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Re-enables the ZIHPM extension flag in the ISA parser to allow unprivileged performance counters (U-mode) in line with upstream Ibex support.
Changes:
- Enable
EXT_ZIHPMby default for backward compatibility. - Remove/replace the Ibex-specific comment that previously disabled ZIHPM.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -36,7 +36,7 @@ isa_parser_t::isa_parser_t(const char* str, const char *priv) | |||
| max_isa = reg_t(2) << 62; | |||
| // enable zicntr and zihpm unconditionally for backward compatibility | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding support for the U-mode performance counters in lowRISC/ibex#2403. Therefore, we are re-enabling them here as well.