[crypto/25519] Add sideload support for x25519#30047
Merged
Merged
Conversation
siemen11
requested review from
andrea-caforio,
johannheyszl,
nasahlpa and
timothytrippel
and removed request for
a team and
timothytrippel
andrea-caforio
approved these changes
May 7, 2026
Contributor
andrea-caforio
left a comment
andrea-caforio
left a comment
There was a problem hiding this comment.
Thanks @siemen11. Looks good to me.
Comment on lines
+133
to
+134
| bn.wsrr w7, 4 | ||
| bn.wsrr w8, 6 |
Contributor
There was a problem hiding this comment.
Suggested change
| bn.wsrr w7, 4 | |
| bn.wsrr w8, 6 | |
| bn.wsrr w7, KEY_S0_L | |
| bn.wsrr w8, KEY_S1_L |
siemen11
force-pushed
the
x25519_sideload
branch
2 times, most recently
from
ccd48da to
c32b284
Compare
Add sideload support for the keygen and ecdh for x25519 and include a new functest for it. Switch the keymgr tests to the new 25519 apps. Signed-off-by: Siemen Dhooghe <sdhooghe@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sideload support for the keygen and ecdh for x25519 and include a new functest for it.