Repository navigation
Bones:bone. Add random bone and random rotation. LG-2056. - #2426
Open
Shojo-muheheheh wants to merge 1 commit into
Open
Shojo-muheheheh wants to merge 1 commit into
Shojo-muheheheh wants to merge 1 commit into
Conversation
alek13
requested changes
Oct 26, 2026
Comment on lines
+14
to
+17
| core.register_craftitem('bones:bone_2', { | ||
| description = S('Bone'), | ||
| inventory_image = 'bones_bone_inv.png', | ||
| }) |
| or itemstack | ||
| end, | ||
| }) | ||
| core.override_item('bones:bone_2', { |
Member
There was a problem hiding this comment.
не нужно, нужен только math.random(1, 2) или 3, если их будет 3
| drop = 'bones:bone', | ||
| node_box = { | ||
| type = "fixed", | ||
| fixed = { |
Member
There was a problem hiding this comment.
мелочь: у первого и седьмого боксов min > max по X и Z, порядок боксов перепутан
| }, | ||
| }, | ||
| }) | ||
| core.register_node("bones:bone_2", { |
Member
There was a problem hiding this comment.
лучше общие свойства вынести в отдельную таблицу common_definition и в обоих случаях делать table.merge().
и мы вроде 3 варианта хотели ? или я запамятовал ?
| }, | ||
| }, | ||
| }) | ||
| core.register_node("bones:bone_2", { |
Member
There was a problem hiding this comment.
одинарные кавычки, см. код-стайл
Suggested change
| core.register_node("bones:bone_2", { | |
| core.register_node('bones:bone_2', { |
| paramtype = 'light', | ||
| paramtype2 = 'facedir', | ||
| is_ground_content = false, | ||
| drawtype = "nodebox", |
Member
There was a problem hiding this comment.
одинарные кавычки, выравнивание, см. код-стайл
Suggested change
| drawtype = "nodebox", | |
| drawtype = 'nodebox', |
| groups = { dig_immediate = 2 }, | ||
| drop = 'bones:bone', | ||
| node_box = { | ||
| type = "fixed", |
Member
There was a problem hiding this comment.
одинарные кавычки, выравнивание, см. код-стайл
Suggested change
| type = "fixed", | |
| type = 'fixed', |
alek13
reviewed
Oct 26, 2026
| tiles = { 'bones_bone.png' }, | ||
| groups = { dig_immediate = 2 }, | ||
| drop = 'bones:bone', | ||
| node_box = { |
Member
There was a problem hiding this comment.
Suggested change
| node_box = { | |
| node_box = { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавил новую модель миниатюрной кости.
Теперь при установке кости появляется рандомная модель.
Uploading bones_random.mp4…