editor: add clickable breakpoint gutter - #2619
Open
gintsgints wants to merge 3 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
huacnlee
requested changes
Jul 30, 2026
huacnlee
left a comment
Member
There was a problem hiding this comment.
I don't think this is a good API design.
Contributor
Author
You think that gutter idea is bad at all or you think realisation need improvement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional clickable breakpoint gutter to the multi-line editor (
InputState), rendered as dots to the left of the line numbers — like the debug gutter in a code editor.danger).InputEvent::BreakpointToggled(line)(0-based buffer row).API
InputState:breakpoints_enabled(bool)— builder to enable the gutter (requires line numbers).set_breakpoints_enabled(bool, cx)/is_breakpoints_enabled()— runtime toggle + getter.breakpoints()/set_breakpoints(set, cx)— read/replace the breakpoint lines.toggle_breakpoint(line, cx)— toggle a single line.InputEvent::BreakpointToggled(usize)— emitted on toggle.Notes
Gutter width reserves
BREAKPOINT_DOT_WIDTHonly when enabled, so existing editors are unaffected. Layout/paint mirrors the existing fold-icon path (layout_fold_icons).AI-assisted; reviewed and refactored to match project style.