Skip to content

test(integration-tests): add multi pathogen revocation test - #5616

Merged
fengelniederhammer merged 3 commits into
mainfrom
evSearchTests
Dec 8, 2025
Merged

test(integration-tests): add multi pathogen revocation test#5616
fengelniederhammer merged 3 commits into
mainfrom
evSearchTests

Conversation

@fengelniederhammer

@fengelniederhammer fengelniederhammer commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Expect test failure, see #5619

🚀 Preview: Add preview label to enable

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Dec 3, 2025
@fengelniederhammer

Copy link
Copy Markdown
Contributor Author

The test works. It found #5619.

@fengelniederhammer fengelniederhammer changed the title evTests: wip test(integration-tests): add multi pathogen revocation test Dec 3, 2025
Comment thread kubernetes/loculus/values.yaml Outdated
@corneliusroemer
corneliusroemer marked this pull request as ready for review December 3, 2025 17:46
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@corneliusroemer corneliusroemer removed the preview Triggers a deployment to argocd label Dec 3, 2025
@anna-parker

Copy link
Copy Markdown
Contributor

should this be rebased on #5626?

@anna-parker anna-parker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@corneliusroemer

Copy link
Copy Markdown
Contributor

@fengelniederhammer Shall we merge this one to prevent more conflicts piling up in the future?

@fengelniederhammer

Copy link
Copy Markdown
Contributor Author

@fengelniederhammer Shall we merge this one to prevent more conflicts piling up in the future?

I'd delay it until #5382 is merged to main. This PR is 4 layers up in the stack of PR. I'd rather just rebase once more before the final merge and not bother with rebasing those PRs until then. It's a waste of time.

Base automatically changed from no_waitForLoculusId to main December 8, 2025 07:17
@fengelniederhammer
fengelniederhammer merged commit 557e261 into main Dec 8, 2025
40 checks passed
@fengelniederhammer
fengelniederhammer deleted the evSearchTests branch December 8, 2025 07:40
maverbiest pushed a commit that referenced this pull request Dec 8, 2025
Expect test failure, see #5619

🚀 Preview: Add `preview` label to enable

---------

Co-authored-by: Cornelius Roemer <cornelius.roemer@gmail.com>
fengelniederhammer added a commit that referenced this pull request Dec 9, 2025
…entries (#5626)

resolves #5619

### Screenshot

### PR Checklist
~~- [ ] All necessary documentation has been adapted.~~
- [x] The implemented feature is covered by appropriate, automated
tests.
  - #5616 
- [x] Any manual testing that has been done is documented (i.e. what
exactly was tested?)
Anya notes: revoked the sequence LOC_003MSV5.1 and confirmed page still
works:
<img width="2358" height="486" alt="image"
src="https://github.com/user-attachments/assets/87c78c53-196e-40de-81a0-bda6021ca713"
/>
<img width="2582" height="692" alt="image"
src="https://github.com/user-attachments/assets/0a4c812f-7835-4c92-8e05-8444a0f90d9c"
/>


🚀 Preview: https://5619-missing-genotype-of.loculus.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants