[LLVM] Set SOVERSION on shared libraries on macOS#188982
Closed
vadorovsky wants to merge 1 commit intollvm:mainfrom
Closed
[LLVM] Set SOVERSION on shared libraries on macOS#188982vadorovsky wants to merge 1 commit intollvm:mainfrom
vadorovsky wants to merge 1 commit intollvm:mainfrom
Conversation
`LLVM_VERSION_SUFFIX` currently behaves inconsistently on macOS and other Unix-like systems. On macOS, libLLVM is emitted as an unversioned library with a compatibility symlink: libLLVM-22-[suffix].dylib -> libLLVM.dylib libLLVM.dylib On Linux, the library filename itself carries the version suffix, and both the compatibility symlink and the unversioned linker name point to it: libLLVM-22[suffix].so -> libLLVM.so.22.1[suffix] libLLVM.so -> libLLVM.so.22.1[suffix] libLLVM.so.22.1[suffix] The macOS layout makes it harder to install multiple LLVM builds side by side without library name collisions. Make macOS follow the same versioned shared-library naming scheme as other Unix-like systems by setting `SOVERSION` for shared libraries there as well. Fixes llvm#188963
Contributor
Author
|
Superseded by #189004 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM_VERSION_SUFFIXcurrently behaves inconsistently on macOS and other Unix-like systems.On macOS, libLLVM is emitted as an unversioned library with a compatibility symlink:
On Linux, the library filename itself carries the version suffix, and both the compatibility symlink and the unversioned linker name point to it:
The macOS layout makes it harder to install multiple LLVM builds side by side without library name collisions.
Make macOS follow the same versioned shared-library naming scheme as other Unix-like systems by setting
SOVERSIONfor shared libraries there as well.Fixes #188963