Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
HIPjob inCI.ymlbuilds Kokkos (HIP) and ExaCA but does not run anything, because the runners have no GPU. This adds a separate, optional workflow.github/workflows/gpu-sim.ymlthat builds the same way (Kokkos 4.2.00, nlohmann_json 3.11.2,hipcc, Release) for gfx942 and runs theunit_test/gtests on a simulated AMD Instinct MI300X using PantheonSim (no GPU needed). I am the author of PantheonSim, so please weigh this accordingly.It touches no source file, does not change
CI.ymland is not meant to be a required check. A simulator cannot reproduce hardware-specific behavior or timing, so it complements real-GPU testing and does not replace it.What it does:
rocthrust-dev,rocprim-dev, OpenMPI and GoogleTest with apt-DKokkos_ENABLE_HIP=ON -DKokkos_ARCH_AMD_GFX942=ON, then ExaCA withExaCA_ENABLE_TESTING=ON,hipccand the same MPI flags as theHIPjob (without-Werror)vgpu run ctest -R _HIP_with up to 2 MPI ranksmasterthat touchsrc,unit_test,examples,cmakeorCMakeLists.txt, with a concurrency group that cancels superseded runsMeasured:
Not covered (excluded in the workflow, with the reason in a comment). These HIP tests fail on the current sources and do not look like simulator problems, but I have not confirmed them on real hardware:
Orientation: the test buildsgrain_id_converted_hostwithcreate_mirror_view(HostSpace(), ...), which does not copy the device data, then compares it.Interface(cell_update_tests): Kokkos aborts with "attempt to access inaccessible memory space (label=GrainID)", i.e. the test reads a device view on the host.Nucleation: the test reassigns its localgrain_idview to a copy and checks that, instead of the cell data the kernel modified.Updateon 2 ranks:MPI_Isendof a device pointer segfaults with the apt OpenMPI, which is not GPU-aware.SERIALvariants of every test (Kokkos built with HIP only for this job) and the example-input runs fromCI.yml.If you would rather fix those tests on a GPU backend first, I am happy to help; otherwise the exclusion list can be shrunk as they get fixed.