Skip to content

updating CHAI to c++20 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kab163 wants to merge 7 commits into from
Closed

updating CHAI to c++20 #363

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4de793
updating CHAI to c++20
kab163 Apr 13, 2026
0c8268d
Merge branch 'develop' into task/update-to-c++20
rhornung67 May 26, 2026
57e9f00
Update gitignore and release notes
adayton1 May 26, 2026
9dbced0
Update RAJA and Umpire
adayton1 May 26, 2026
dc59ee7
Update to newer gcc docker image
adayton1 May 26, 2026
e724018
Merge branch 'develop' into task/update-to-c++20
adayton1 May 27, 2026
3fa1d45
Merge branch 'develop' into task/update-to-c++20
adayton1 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ message(STATUS "Using CMake version ${CMAKE_VERSION}")
################################
# BLT
################################
set(BLT_CXX_STD c++17 CACHE STRING "")
set(BLT_CXX_STD c++20 CACHE STRING "")

if(("${BLT_CXX_STD}" STREQUAL "c++98") OR
("${BLT_CXX_STD}" STREQUAL "c++11") OR
("${BLT_CXX_STD}" STREQUAL "c++14"))
message(FATAL_ERROR "CHAI requires a minimum C++ standard of c++17. Please set BLT_CXX_STD appropriately.")
("${BLT_CXX_STD}" STREQUAL "c++14") OR
("${BLT_CXX_STD}" STREQUAL "c++17"))
message(FATAL_ERROR "CHAI requires a minimum C++ standard of c++20. Please set BLT_CXX_STD appropriately.")
endif()

if (NOT BLT_LOADED)
Expand Down
5 changes: 5 additions & 0 deletions tests/integration/managed_ptr_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
//////////////////////////////////////////////////////////////////////////////
#include "gtest/gtest.h"

#define CHAI_USE_VAR(x) static_cast<void>(x)

#define GPU_TEST(X, Y) \
static void gpu_test_##X##Y(); \
TEST(X, Y) { gpu_test_##X##Y(); } \
Expand Down Expand Up @@ -872,6 +874,8 @@ class ABase {
// Virtual function to manipulate an array of objects
CHAI_HOST_DEVICE virtual void setArrayValues(int size, int value) {
// Base implementation does nothing
CHAI_USE_VAR(size);
CHAI_USE_VAR(value);
}

CHAI_HOST_DEVICE virtual int getTypeID() const { return 0; }
Expand Down Expand Up @@ -919,6 +923,7 @@ TEST(managed_ptr, polymorphic_with_ManagedArray_unpacker)
// Use virtual function to modify array through the member pointer
const int base_value = 10;
forall( sequential(), 0, 1,[=](int i ) {
CHAI_USE_VAR(i);
poly_ptr->setArrayValues(size, base_value);
});

Expand Down