feat: show estimated tx cost in confirmation step#3907
Open
597226617 wants to merge 1 commit into
Open
Conversation
Implements livepeer#1815 - Show estimated tx cost before transaction submission Changes: - Add /estimateTxCost server endpoint for gas estimation - Add confirmTx() helper in CLI wizard - Add confirmation prompts to all transaction wizards: bond, rebond, unbond, withdrawStake, withdrawFees, initializeRound, activateOrchestrator, fundDepositAndReserve, unlock, withdraw - Add EstimateTransferGas to eth client interface Closes livepeer#1815, relates to livepeer#1783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #1815 - Add estimated transaction cost display and confirmation step before submitting on-chain transactions.
Changes
Server-side
/estimateTxCostendpoint (server/handlers.go): AcceptstxTypequery param, returns estimated gas cost in ETH based on current gas price and typical gas limits per tx typeserver/webserver.goCLI-side
confirmTx()helper (cmd/livepeer_cli/wizard.go): Queries/estimateTxCost, displays estimated cost, prompts user for y/N confirmationbond,rebond,unbond,withdrawStake,withdrawFees(wizard_bond.go)initializeRound(wizard_rounds.go)activateOrchestrator(wizard_transcoder.go)fundDepositAndReserve,unlock,withdraw(wizard_ticketbroker.go)ETH Client
EstimateTransferGasmethod toeth/client.gointerfaceUser Experience
Closes #1815
Relates to #1783