redis: honour dial/read/write timeouts in all modes, not just Sentinel - #1734
Open
distronode-com wants to merge 1 commit into
Open
redis: honour dial/read/write timeouts in all modes, not just Sentinel#1734distronode-com wants to merge 1 commit into
distronode-com wants to merge 1 commit into
Conversation
RedisConfig exposes dial_timeout, read_timeout and write_timeout, but GetRedisClient only reads them in the Sentinel branch. A single-address or cluster deployment can set them and they are silently ignored -- nothing errors and nothing warns. Pass them through in all three branches. Sentinel keeps its existing 2000/200/200 defaults; the other two leave an unset value at zero so go-redis applies its own defaults, so a config that does not set them behaves exactly as before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: ff57e7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RedisConfigexposesdial_timeout,read_timeoutandwrite_timeout, butGetRedisClientonly reads them in the Sentinel branch. A single-address or cluster deployment can set them and they are silently ignored — nothing errors and nothing warns.This passes them through in all three branches. Sentinel keeps its existing 2000/200/200 defaults; the other two leave an unset value at zero so go-redis applies its own defaults, so a config that does not set them behaves exactly as before.
How it turned up
Debugging a self-hosted SFU where
RedisRouter.statsWorkerstalled ~31s and loggedstatus update delayed, possible deadlock, with the goroutine parked in go-redisConnPool.queuedNewConn.That stall is not reachable from config today.
PoolTimeoutbounds onlywaitTurn;pool.gonotes thatqueuedNewConndeliberately applies no timeout of its own becausedialConnappliesDialTimeoutper attempt — anddialConnretriesDialerRetries(default 5) times. WithDialTimeoutnever passed through on the simple path, there is no way to bound that from YAML.The knock-on effect is user visible: while
statsWorkeris stalled the node'sStats.UpdatedAtgoes stale, andLivekitServer.healthCheckreturns 406 once it is more than 4s old. Anything using/as a health probe sees the node as unhealthy.Notes
gofmt,go build ./redis/...andgo vet ./redis/...all clean.