simulate: audio subcommand with impairment flags - #943
Draft
u9g wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns
--audiointo anaudiosubcommand, which carries three new booleans sent on the create-simulation message:simulate's own flags did not need duplicating on the subcommand: urfave/cli v3 flags are persistent unlessLocalis set, so--scenarios,--agent-name,-nand friends parse on either side ofaudio. Since v3's help only renders the root's persistent flags under GLOBAL OPTIONS, the subcommand carries a one-line description pointing back at them.Verified against a local fake twirp endpoint:
lk agent simulate audio --background-noise --low-quality-microphone --packet-losssendswhile plain
lk agent simulatestill sendsSIMULATION_MODE_TEXTwith no impairments, and the impairment flags are rejected on the parent command.Draft, blocked on livekit/protocol#1723: the fields land on
SimulationRun.Create.Requestthere, so CI cannot compile until that publishes and the dependency is bumped here.Breaking:
--audioshipped in v2.18.2 and is removed by this change, replaced by the subcommand. Say the word if it should stay as a hidden alias.