fix(deepgram): avoid unset redact param#1893
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d4fe810 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redactquery parameter for streaming Deepgram STT@livekit/agents-plugin-deepgramTesting
pnpm --filter @livekit/agents-plugin-deepgram lint(passes with existing warnings)pnpm --filter @livekit/agents buildpnpm --filter @livekit/agents-plugin-silero buildpnpm --filter @livekit/agents-plugins-test buildpnpm --filter @livekit/agents-plugin-openai buildpnpm --filter @livekit/agents-plugin-deepgram buildpnpm prettier --check plugins/deepgram/src/stt.ts .changeset/deepgram-redact-param.mdPorted from livekit/agents#6245
Original PR description
PR #5362 re-added a
redactparameter to the Deepgram STT plugin that already existed, producing duplicate function arguments acrossSTTOptions, bothupdate_optionsmethods, and the streaming config.Because duplicate arguments are a Python
SyntaxError,livekit.plugins.deepgram.sttcould no longer be imported — the STT plugin was fully broken on main.This removes the duplicate and keeps the pre-existing
redactwiring (the more permissivestr | list[str]type), leaving the genuinely newreplace,search,utterance_end_ms, anddictationparams from #5362 intact.