fix(worker): exit after max connection retries#1889
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
fix(worker): exit after max connection retries#1889rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 7ab52ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run()fails so cleanup does not hangclose()calls no-op after a terminal run failureTesting
pnpm test agents/src/worker.test.tspnpm build:agentspnpm --filter @livekit/agents lint(existing warnings only)Ported from livekit/agents#6103
Original PR description
Fixes #6083.
When the worker connects to a wrong or unreachable URL, it never exits after exhausting
max_retry— it hangs as a zombie, and a usertry/exceptaroundserver.run()never catches the error.AgentServer.run()completes only when_close_futureresolves, which happens exclusively inaclose(). The connection task is fire-and-forget: it's created and appended to a localtaskslist that is never awaited or watched. When_connection_taskexhaustsmax_retryit raisesRuntimeError, but that exception dies on the orphaned task. Nothing resolves_close_future, sorun()blocks forever, the CLI'sexcept Exceptionnever fires (no drain/exit), and callers'try/exceptcatches nothing.This adds a done callback on the connection task that propagates its terminal exception to
_close_future, sorun()re-raises it. The CLI then logsworker failedand runs its normal drain/aclose teardown so the process exits, and a usertry/exceptaroundserver.run()finally catches the failure.Scoped to the connection task only — not the load task, whose failures are logged-and-continue today and should not start crashing the worker.