fix(rime): send language parameter for TTS#1887
Open
chasef07 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: a6041a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
languageas the preferred Rime TTS language option while keepinglangas a deprecated compatibility alias.languagefor both HTTP and WebSocket TTS requests.langfallback, and WebSocket query parameters.Why
The Rime API expects the language selection under the
languageparameter. The current JS plugin exposeslangand forwardslanginto Rime request parameters, which makes code using the documented Rime parameter shape harder to write and can silently send the wrong query key.This keeps the existing
langoption working for users who already depend on it, but preferslanguagewhen both are provided so new code can use the provider's documented API spelling.Validation
pnpm exec vitest run plugins/rime/src/tts.test.tspnpm --filter @livekit/agents-plugin-rime lintpnpm exec prettier --check plugins/rime/src/tts.ts plugins/rime/src/tts.test.ts .changeset/rime-language-param.mdpnpm --filter @livekit/agents-plugin-rime buildI also ran
pnpm --filter @livekit/agents-plugin-rime api:check; it reached API Extractor but exited nonzero on the existing missing API report/release-tag warnings for this plugin rather than a new type error.