fix(agents): stop forwarding frame processor info#1883
fix(agents): stop forwarding frame processor info#1883rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 61bff05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Duplicate of #1881, closing. |
| token: this.room.token!, | ||
| url: this.room.serverUrl!, | ||
| }); | ||
| return true; |
There was a problem hiding this comment.
🚩 FrameProcessor no longer receives stream context or credentials after track subscription
The removed code at agents/src/voice/room_io/_input.ts:155-164 (old lines) forwarded participant identity, room name, publication SID, token, and server URL to the FrameProcessor whenever a new track was subscribed, and refreshed credentials on token refresh. After this PR, the FrameProcessor still receives audio frames via AudioStream (agents/src/voice/room_io/_input.ts:159-164), but it no longer has access to the stream metadata or LiveKit credentials. If any FrameProcessor implementation (e.g., a cloud-based noise cancellation service) relies on these callbacks to authenticate or route audio, it would silently stop working. The changeset description explicitly states this is intentional, so this is likely coordinated with an update in @livekit/rtc-node where AudioStream now handles this internally. Worth confirming with the rtc-node team that the FrameProcessor contract no longer requires these calls.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Testing
Ported from livekit/agents#5867
Original PR description
Delegate sending stream info to the frame processor to the client sdk AudioStream instead of doing it all at the agents sdk level.
Depends on livekit/python-sdks#679 - all the
FrameProcessor-related code removed in here has been moved into the underlying python sdk.TODO
python-sdksto the ^ above, which will fix the ci build error