chore(deps): bump ws from 8.20.1 to 8.21.0 in the npm_and_yarn group across 1 directory#1874
chore(deps): bump ws from 8.20.1 to 8.21.0 in the npm_and_yarn group across 1 directory#1874dependabot[bot] wants to merge 1 commit into
Conversation
|
| }, | ||
| "dependencies": { | ||
| "ws": "^8.16.0" | ||
| "ws": "^8.21.0" |
There was a problem hiding this comment.
🟡 assemblyai plugin uses hardcoded ws version instead of catalog: like all other plugins
Every other plugin in the repository (anam, baseten, cartesia, deepgram, elevenlabs, fishaudio, inworld, liveavatar, minimax, neuphonic, openai, resemble, rime, sarvam, silero, soniox, xai) specifies "ws": "catalog:" which resolves to ^8.18.0 from pnpm-workspace.yaml. The assemblyai plugin instead uses a hardcoded version (^8.21.0), which means it won't benefit from centralized version management. If the catalog ws version is updated in the future, assemblyai will be missed. The PR should have switched this to "ws": "catalog:" and, if needed, bumped the catalog version in pnpm-workspace.yaml to ^8.21.0.
Prompt for agents
The assemblyai plugin hardcodes its ws dependency version as "^8.21.0" rather than using "catalog:" like all other plugins. To fix this consistently:
1. In plugins/assemblyai/package.json, change `"ws": "^8.21.0"` to `"ws": "catalog:"`
2. In pnpm-workspace.yaml, update the catalog entry for ws from `^8.18.0` to `^8.21.0` so all plugins get the security fix
This ensures centralized version management and that the security bump applies consistently across all plugins.
Was this helpful? React with 👍 or 👎 to provide feedback.
| }, | ||
| "dependencies": { | ||
| "ws": "^8.16.0" | ||
| "ws": "^8.21.0" |
There was a problem hiding this comment.
🚩 Security bump scope may be incomplete across the monorepo
The pnpm-workspace.yaml catalog defines ws: ^8.18.0, which all plugins except assemblyai reference via catalog:. Since ^8.18.0 already satisfies >=8.21.0 in semver resolution, the actual installed version in the lockfile may already be 8.21.x for all plugins depending on when pnpm install was last run. However, the catalog minimum floor remains at ^8.18.0, meaning a fresh install could theoretically resolve to 8.18.0–8.20.x for the other plugins if those versions are still available. If this bump is motivated by a security fix in ws 8.21.0, the catalog version in pnpm-workspace.yaml:24 should also be bumped to ensure all plugins enforce the minimum safe version.
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps the npm_and_yarn group with 1 update in the / directory: [ws](https://github.com/websockets/ws). Updates `ws` from 8.20.1 to 8.21.0 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.20.1...8.21.0) --- updated-dependencies: - dependency-name: ws dependency-version: 8.21.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
42df6bd to
008a40f
Compare
Bumps the npm_and_yarn group with 1 update in the / directory: ws.
Updates
wsfrom 8.20.1 to 8.21.0Release notes
Sourced from ws's releases.
Commits
bca91ad[dist] 8.21.02b2abd4[security] Limit retained message parts78eabe2[security] Add latest vulnerability to SECURITY.md