-
Notifications
You must be signed in to change notification settings - Fork 199
Add Huion Inspiroy H610Pro v2 #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kortschak
wants to merge
1
commit into
linuxwacom:master
Choose a base branch
from
kortschak:huion-inspiroy-h610pro-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Huion | ||
| # Inspiroy H610Pro v2 | ||
| # | ||
| # sysinfo.fcHjk6pvOB.tar.gz | ||
| # https://github.com/linuxwacom/wacom-hid-descriptors/issues/630 | ||
|
|
||
| [Device] | ||
| Name=HUION Inspiroy H610Pro v2 | ||
| ModelName=Inspiroy H610Pro v2 | ||
| DeviceMatch=usb|256c|006d||HUION_T184 | ||
| Width=10 | ||
| Height=6 | ||
| Layout=huion-h610-pro.svg | ||
| Styli=@generic-no-eraser; | ||
| IntegratedIn= | ||
|
|
||
| [Features] | ||
| NumStrips=0 | ||
| NumRings=0 | ||
| Reversible=true | ||
| Stylus=true | ||
| Touch=false | ||
| TouchSwitch=false | ||
|
|
||
| [Buttons] | ||
| Left=A;B;C;D;E;F;G;H | ||
| EvdevCodes=BTN_0;BTN_1;BTN_2;BTN_3;BTN_4;BTN_5;BTN_6;BTN_7 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we already have this device from #965 but the match unintentionally included the firmware date suffix
_190313. If you remove that from./data/huion-h610-pro-v2.tabletdoes it work for you? the rest is the same afaict.If it works, can you update the PR (or file a new one) removing that suffix please? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is matching performed with prefix matching, or exact matching. If I remove the suffix and it's exact matching the currently supported tablet firmware version will cease to work. Also, for the follow-up I'd like to fix the file name to follow conventions; is that too much diff noise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should ignore the suffix, see the code here.
Maybe a stray underscore?
Oh, and note that #965 also included the name in the match (
HUION Huion Tablet), if your device has a different name (e.g. aPenorPadsuffix) that'll be the reason for the failed match. Remove the name match too so it matches yourDeviceMatchline and that should work, assuming no other bug has snuck in somewhere.Just keep that change as a separate commit and you can make all the noise you want ;)