Refactor/replace code for more portability (part 1)

[igaw]

A bunch of functions are not easy portable, thus try to get rid of the by either refactor/replace the code so these are not used anymore.

These are changes based on #3310

[igaw]

@bgoing-micron-oss the next PR ontop of the memory API changes.

[igaw]

@bjpaupor quick question on nvme-models.c You were the last one to really change something on this file back in 2021. Somewhere later we dropped to the call to open_pci_ids, basically turning the whole nvme-models.c code abandon. Do you still need this, should we revive it?

[igaw]

@bjpaupor Forget it, I just brought the feature back :)

[Copilot]

Pull request overview

This PR aims to improve Windows portability by removing/avoiding non-portable libc APIs (dprintf, getline, open_memstream) and plumbing a device-derived “product name” into the identify controller output path.

Changes:

• Replaced dprintf() usage in libnvme logging with a buffer + write loop approach.
• Replaced getline() usage with fgets() in a couple of parsing/reading paths.
• Extended the id_ctrl printing API to optionally include a derived product_name in stdout/JSON output.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
plugins/micron/micron-nvme.c	Updates nvme_show_id_ctrl() call site to pass transport handle name.
nvme.c	Updates nvme_show_id_ctrl() call site to pass transport handle name.
nvme-print.h	Changes print_ops->id_ctrl and nvme_show_id_ctrl() signatures to carry product/device name context.
nvme-print.c	Computes product_name via nvme_product_name(devname) and passes it into the print backend.
nvme-print-stdout.c	Prints product_name before the controller identify output; removes open_memstream usage in effects log printing.
nvme-print-json.c	Adds product_name to JSON identify-controller output.
nvme-print-binary.c	Updates binary identify-controller print signature to match new print_ops.
nvme-models.h	Changes nvme_product_name() to accept a device name string rather than an integer id.
nvme-models.c	Replaces getline() with fgets(); adds device-name parsing to obtain controller instance id.
libnvme/src/nvme/log.c	Replaces dprintf() with asprintf() + write_all() implementation.
libnvme/src/nvme/linux.c	Replaces getline() with fgets() for reading product_uuid; adds additional validation.
libnvme/src/meson.build	Moves nvme/log.c into unconditional sources list (now built on Windows too).

Comments suppressed due to low confidence (1)

libnvme/src/nvme/log.c:119

• Calling perror() here introduces an unconditional stderr side effect from inside the library logging path, which can surprise consumers (and may recurse if stderr logging is also routed back into libnvme). Prefer returning silently, or reporting the failure via the existing libnvme logging mechanism/state rather than printing directly to stderr.

	if (write_all(l->fd, log, strlen(log)) < 0)
		perror("failed to write log entry");

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[igaw]

let's go with this set of changes. more to come...