Skip to content

usb: add PID 0x90db and refactor PID check#218

Open
mukeshojha-linux wants to merge 1 commit into
linux-msm:masterfrom
mukeshojha-linux:add0x90db
Open

usb: add PID 0x90db and refactor PID check#218
mukeshojha-linux wants to merge 1 commit into
linux-msm:masterfrom
mukeshojha-linux:add0x90db

Conversation

@mukeshojha-linux
Copy link
Copy Markdown
Contributor

Add PID 0x90db used by some Qualcomm targets in EDL mode. Also refactor usb_try_open() to use usb_is_edl_pid() instead of a duplicate hardcoded PID list, so future PID additions only need a single change.

Add PID 0x90db used by some Qualcomm targets in EDL mode.  Also refactor
usb_try_open() to use usb_is_edl_pid() instead of a duplicate hardcoded
PID list, so future PID additions only need a single change.

Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
@andersson
Copy link
Copy Markdown
Collaborator

It used to be that this list gave us "definitive" answer that the device is in EDL mode, but if I read correctly this isn't a PID reserved for EDL mode. Is there some other check we should include here?

@mukeshojha-linux
Copy link
Copy Markdown
Contributor Author

It used to be that this list gave us "definitive" answer that the device is in EDL mode, but if I read correctly this isn't a PID reserved for EDL mode. Is there some other check we should include here?

If I remember correctly, I did the change as device was not detecting in crash dump mode after crash., there device manager was showing (0x90db as pid) let me recheck this.

@andersson
Copy link
Copy Markdown
Collaborator

Yes, that part is correct. But what I'm saying is that 0x90db seems to be used for non-ramdump use cases as well. What I'm looking for is confirmation that we have the right checks in place to not attempt to do ramdump on such alternative cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants