misc: changed file loading so that all files are searched for in the include directory#214
misc: changed file loading so that all files are searched for in the include directory#214Zephyrus29 wants to merge 1 commit into
Conversation
45e8f05 to
0ecef83
Compare
…include directory This changes the file path search logic everywhere so that it looks for every file in the include dir This changes someone calling it like this qdl -i foo foo/prog_firehose_ddr.elf foo/rawprogram*.xml foo/patch*.xml to qdl -i foo prog_firehose_ddr.elf rawprogram*.xml patch*.xml which makes running scripts from external directories easier Signed-off-by: Nicholas Hunn <nicholas.hunn4568@gmail.com>
0ecef83 to
c6d1b81
Compare
|
Thank you for your PR, @Zephyrus29. I typically just step into "foo" and run the command from there, so this problem hasn't really dawned on me. But I agree the current scheme is rather unintuitive. I did play around with this a bit; one thing I don't like with your proposed form is that I can't tab-complete any of the filenames. I need to type them out in full, relative to the path I provided through -i. The result of this ended up being #223 where I propose we look for files adjacent to the rawprogramN.xml file that referenced the file (with -i as a higher priority override option). Your proposed command becomes: This removes the unintuitive requirement of specifying -i when you already told the tool where to find the thing you want to flash. |
This changes the file path search logic everywhere so that it looks for every file in the include dir
This changes someone calling it like this
qdl -i foo foo/prog_firehose_ddr.elf foo/rawprogram*.xml foo/patch*.xml
to
qdl -i foo prog_firehose_ddr.elf rawprogram*.xml patch*.xml