Skip to content

misc: changed file loading so that all files are searched for in the include directory#214

Open
Zephyrus29 wants to merge 1 commit into
linux-msm:masterfrom
Zephyrus29:feature/allFilesIncdir
Open

misc: changed file loading so that all files are searched for in the include directory#214
Zephyrus29 wants to merge 1 commit into
linux-msm:masterfrom
Zephyrus29:feature/allFilesIncdir

Conversation

@Zephyrus29
Copy link
Copy Markdown

This changes the file path search logic everywhere so that it looks for every file in the include dir

This changes someone calling it like this
qdl -i foo foo/prog_firehose_ddr.elf foo/rawprogram*.xml foo/patch*.xml

to

qdl -i foo prog_firehose_ddr.elf rawprogram*.xml patch*.xml

@Zephyrus29 Zephyrus29 force-pushed the feature/allFilesIncdir branch from 45e8f05 to 0ecef83 Compare April 20, 2026 22:32
…include directory

This changes the file path search logic everywhere so that it looks for every file in the include dir

This changes someone calling it like this
qdl -i foo foo/prog_firehose_ddr.elf foo/rawprogram*.xml foo/patch*.xml
to
qdl -i foo prog_firehose_ddr.elf rawprogram*.xml patch*.xml

which makes running scripts from external directories easier

Signed-off-by: Nicholas Hunn <nicholas.hunn4568@gmail.com>
@Zephyrus29 Zephyrus29 force-pushed the feature/allFilesIncdir branch from 0ecef83 to c6d1b81 Compare April 22, 2026 23:05
@quic-bjorande
Copy link
Copy Markdown
Contributor

Thank you for your PR, @Zephyrus29.

I typically just step into "foo" and run the command from there, so this problem hasn't really dawned on me. But I agree the current scheme is rather unintuitive.

I did play around with this a bit; one thing I don't like with your proposed form is that I can't tab-complete any of the filenames. I need to type them out in full, relative to the path I provided through -i.

The result of this ended up being #223 where I propose we look for files adjacent to the rawprogramN.xml file that referenced the file (with -i as a higher priority override option).

Your proposed command becomes:
qdl foo/prog_firehose_ddr.elf foo/rawprogram*.xml foo/patch*.xml

This removes the unintuitive requirement of specifying -i when you already told the tool where to find the thing you want to flash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants