Conversation
|
Hello! Ok, I'll make tests. |
|
See also: https://github.com/jirwin/burrow_exporter/ (it might make sense to make use of prometheus golang libraries in your PR) |
|
Related issue #318 |
JensRantil
left a comment
There was a problem hiding this comment.
Have you considered using https://godoc.org/github.com/prometheus/client_golang/prometheus instead of generating the https://prometheus.io/docs/instrumenting/exposition_formats/ manually yourself? The benefit of using the library is that you likely won't need to make any code changes if the exposition format changes. Additionally, you don't need to take care of string escaping and other low-level things.
|
Any update on this pull request? @bai is there a chance to get that merged if tests are added? @dmitryilyin do you have the bandwidth to tackle this or would you need help? |
|
I'd personally prefer having a native client_golang implementation since it's proven in production. I personally have no bandwidth to implement it though. I won't hesitate reviewing a PR and releasing it if you or someone else would implement it 🙏 |
|
When will the feature be released? |
|
This issue is outdated. Prometheus metrics were implemented since 1.3.4, see this comment for more details #318 (comment) |

Add Prometheus metrics endpoint at "/metrics" with topic and consumer group measurements.