Skip to content

Introduce RequestLogListener #6543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikhoon merged 3 commits into from
Dec 11, 2025
Merged

Introduce RequestLogListener #6543

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e6a33d
Introduce `RequestLogListener`
ikhoon Dec 9, 2025
4ea890e
clean up
ikhoon Dec 9, 2025
a4aa046
address comments by @jrhee17
ikhoon Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions core/src/main/java/com/linecorp/armeria/client/observation/ObservationClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import com.linecorp.armeria.common.RequestHeadersBuilder;
import com.linecorp.armeria.common.annotation.Nullable;
import com.linecorp.armeria.common.annotation.UnstableApi;
import com.linecorp.armeria.common.logging.RequestLogProperty;
import com.linecorp.armeria.internal.common.RequestContextExtension;
import com.linecorp.armeria.server.observation.ObservationService;

Expand Down Expand Up @@ -138,24 +137,26 @@ public HttpResponse execute(ClientRequestContext ctx, HttpRequest req) throws Ex
private static void enrichObservation(ClientRequestContext ctx,
ClientObservationContext clientObservationContext,
Observation observation) {
ctx.log()
.whenAvailable(RequestLogProperty.REQUEST_FIRST_BYTES_TRANSFERRED_TIME)
.thenAccept(requestLog -> observation.event(Events.WIRE_SEND));

ctx.log()
.whenAvailable(RequestLogProperty.RESPONSE_FIRST_BYTES_TRANSFERRED_TIME)
.thenAccept(requestLog -> {
if (requestLog.responseFirstBytesTransferredTimeNanos() != null) {
observation.event(Events.WIRE_RECEIVE);
}
});

ctx.log().whenComplete()
.thenAccept(requestLog -> {
// TODO: ClientConnectionTimings - there is no way to record events
// with a specific timestamp for an observation
clientObservationContext.setResponse(requestLog);
observation.stop();
});
ctx.log().addListener((property, log) -> {
switch (property) {
case REQUEST_FIRST_BYTES_TRANSFERRED_TIME:
observation.event(Events.WIRE_SEND);
break;
case RESPONSE_FIRST_BYTES_TRANSFERRED_TIME:
if (log.responseFirstBytesTransferredTimeNanos() != null) {
observation.event(Events.WIRE_RECEIVE);
}
break;
case ALL_COMPLETE:
// TODO: ClientConnectionTimings - there is no way to record events
// with a specific timestamp for an observation
clientObservationContext.setResponse(log);
observation.stop();
break;
default:
// Do nothing.
break;
}
});
}
}
Loading
Loading